search

vapor / websocket-kit

WebSocket client library built on SwiftNIO
https://docs.vapor.codes/4.0/advanced/websockets/
MIT License
277 stars 79 forks source link

Migrate to localhost tests #100

Closed 0xTim closed 3 years ago

0xTim commented 3 years ago

Remove test dependency on websocket.org as it's been shutdown

Joannis commented 3 years ago

I'd suggest using port 0 on the server, and passing the server's resolved port into the connecting client.

Joannis commented 3 years ago

I just saw you're doing this in Vapor already: https://github.com/vapor/vapor/pull/2671/files#diff-456973bb34b1e846a21133033cd94a4267890718df688109695f0735237a2e7bR8

0xTim commented 3 years ago

@Joannis good point - I thought a lot of that was in Vapor but it's NIO so all good