PopFlamingo commented 2 years ago

This PR intends to fix #29 by using the NIOTransportServices library

gwynne commented 2 years ago

N.B.: Marked semver-minor, as the added dependency on NIOTransportServices is noteworthy in semver terms.

0xTim commented 2 years ago

@PopFlamingo if you can fix the merge conflicts I'll get this merged

PopFlamingo commented 2 years ago

@0xTim @gwynne If you are fine with it I will also drop the watchOS support for now, in my tests it wasn't possible to make it work on Apple Watch because of OS restrictions. IIRC Apple documentation states that some types of apps such as music streaming apps have lower level networking access but I couldn't test it.

0xTim commented 2 years ago

@PopFlamingo fine by me - we can always add it in if someone really wants to make it work

codecov-commenter commented 2 years ago

Codecov Report

Merging #107 (a9d4990) into main (3af54d0) will decrease coverage by 6.87%. The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   73.87%   67.00%   -6.88%     
==========================================
  Files           5        6       +1     
  Lines         490      597     +107     
==========================================
+ Hits          362      400      +38     
- Misses        128      197      +69

Flag	Coverage Δ
unittests	`67.00% <78.57%> (-6.88%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Sources/WebSocketKit/WebSocketClient.swift	`79.33% <78.57%> (-0.30%)`	:arrow_down:
...bSocketKit/Concurrency/WebSocket+Concurrency.swift	`29.78% <0.00%> (ø)`

VaporBot commented 2 years ago

These changes are now available in 2.6.0

vapor / websocket-kit

Add support for NIOTransportServices #107

Codecov Report