Closed tkrajacic closed 1 year ago
Merging #116 (7a5cb18) into main (2ec1450) will decrease coverage by
1.08%
. The diff coverage is53.57%
.
This is obviously something that's going to have to wait for the next major version of Vapor. Will leave it open
This is obviously something that's going to have to wait for the next major version of Vapor. Will leave it open
Maybe I can restructure it into an additive change (e.g. have an overload). Would that work then?
Yeah if you can make it work that would be great
@0xTim now the old API is back. no more version bump needed. there is only new API. I am not sure about the deprecation messages, but the renamed:
variant doesn't help, since it only takes the method name of the new variant, and those are the same (these are just overloads). I don't think it's possible to make Xcode fix-up the code with the overload automatically.
@tkrajacic ok now the Sendable
stuff is finally landed we can pull this in. Once you've updated I'll merge it
@0xTim I rebased this morning. What do you want updated?
@tkrajacic there was a release 10 mins ago to fix the Sendable
issues from yesterday that are causing conflicts in the merge
This PR enables access to the data in the control frames handled via
onPing
/onPong
via a new API with the existingonPing
andonPong
methods being deprecated.