Closed gwynne closed 1 year ago
Merging #132 (f594b5f) into main (e0faccd) will increase coverage by
16.34%
. The diff coverage is91.07%
.
why are you doing breaking changes without declaring a new major version? Minor versions should not have foundational changes these should have had come in version 3.x.x
Reference to captured var 'client' in concurrently-executing code is being derived from:
ws.onPing { [weak self] _ in guard let client = client else { return } // Reference to captured var 'client' in concurrently-executing code self?.logger.debug("[⚡️] 🏓 ping (client.id)") self?._on(ping: client) self?.on(ping: client) }
with all due respect to your great work but async/await should have been added on next version not on minor. forgive me if im mis understating the change.
The issue you're encountering was due to PR #131, which has since been reverted.
@tierracero the changes weren't supposed to be breaking. I checked the newest release with the AwesomeWS library and it compiles fine. Be warned though, the reason why the compiler flagged that as an error and not a warning is because the code is unsafe and will crash if you receive WS data at the same time the setup runs
@0xTim thank you very much have an awesome blessed day :)
Fix for SwiftNIOSSL 2.23.1 breaking the build of the WebSocket tests due to
EVP_PKEY
no longer being visible.Shoutout and thanks to @jhoughjr for reporting the problem!
Additional changes: