search

vapor / websocket-kit

WebSocket client library built on SwiftNIO
https://docs.vapor.codes/4.0/advanced/websockets/
MIT License
272 stars 79 forks source link

Support PMCE on WebSockets #145

Closed jhoughjr closed 10 months ago

jhoughjr commented 1 year ago

This adds PMCE class to handle compression/decompression. A PR is pending in the vapor repo so it can be easily used inside of vapor.

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

jhoughjr commented 1 year ago

Ill see if I can replicate the failure on 5.9-jammy on my ubuntu box perhaps. Having looked it says only that it was cancelled and no indication why.

codecov-commenter commented 1 year ago

Codecov Report

Merging #145 (342c578) into main (a935b63) will decrease coverage by 26.82%. Report is 1 commits behind head on main. The diff coverage is 17.14%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #145 +/- ## =========================================== - Coverage 82.85% 56.03% -26.82% =========================================== Files 6 7 +1 Lines 659 1085 +426 =========================================== + Hits 546 608 +62 - Misses 113 477 +364 ``` | [Files Changed](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor) | Coverage Δ | | |---|---|---| | [Sources/WebSocketKit/PMCE.swift](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9XZWJTb2NrZXRLaXQvUE1DRS5zd2lmdA==) | `1.94% <1.94%> (ø)` | | | [Sources/WebSocketKit/WebSocket.swift](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9XZWJTb2NrZXRLaXQvV2ViU29ja2V0LnN3aWZ0) | `73.17% <40.69%> (-15.88%)` | :arrow_down: | | [Sources/WebSocketKit/WebSocketHandler.swift](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9XZWJTb2NrZXRLaXQvV2ViU29ja2V0SGFuZGxlci5zd2lmdA==) | `58.02% <51.72%> (-4.48%)` | :arrow_down: | | [Sources/WebSocketKit/WebSocketClient.swift](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9XZWJTb2NrZXRLaXQvV2ViU29ja2V0Q2xpZW50LnN3aWZ0) | `90.67% <60.00%> (-4.68%)` | :arrow_down: | | [...urces/WebSocketKit/HTTPUpgradeRequestHandler.swift](https://app.codecov.io/gh/vapor/websocket-kit/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor#diff-U291cmNlcy9XZWJTb2NrZXRLaXQvSFRUUFVwZ3JhZGVSZXF1ZXN0SGFuZGxlci5zd2lmdA==) | `73.77% <100.00%> (+1.84%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/vapor/websocket-kit/pull/145/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=vapor)
jhoughjr commented 10 months ago

Hummingbird will take flight as Vapor dissipates into nothingness.