Close promise not completed

vapor / websocket-kit

WebSocket client library built on SwiftNIO

https://docs.vapor.codes/4.0/advanced/websockets/

MIT License

272 stars 79 forks source link

Close promise not completed #76

Closed tanner0101 closed 4 years ago

tanner0101 commented 4 years ago

In some situations the promise passed to WebSocket.close is not being completed.

lmcd commented 4 years ago

I'm seeing the process occasionally stall when I wait on the close promise

tanner0101 commented 4 years ago

This is potentially related to https://github.com/vapor/vapor/issues/2451. Working on tracking it down.

tanner0101 commented 4 years ago

In case this is related to the previous issue, https://github.com/vapor/vapor/pull/2472 will fix it. @lmcd could you give that patch a try? Assuming you are using Vapor + WebSockets here.