search

vapor / websocket-kit

WebSocket client library built on SwiftNIO
https://docs.vapor.codes/4.0/advanced/websockets/
MIT License
277 stars 79 forks source link

Upgrade swift-nio-ssl to 2.10.2 #83

Closed xanderdunn closed 3 years ago

xanderdunn commented 3 years ago

websocket-kit is currently pegged to swift-nio-ssl 2.0.0. Could you please update this to 2.10.2, which includes a fix that allows swift-nio-ssl to build with Swift For TensorFlow and latest Swift trunk. See apple/swift-nio-ssl#259.

Currently websocket-kit fails to build on Swift For TensorFlow and latest Swift trunk as a result of its swift-nio-ssl dependency version.

Thanks!

0xTim commented 3 years ago

@xanderdunn it should still be possible to build because SwiftPM should take the latest possible version right?

xanderdunn commented 3 years ago

Oh right, the from parameter in Package.swift just begs a lower bound on the version, not an exact version. It does indeed build after swift package update brings swift-nio-ssl up to date. Thanks!

0xTim commented 3 years ago

Yeah from is short hand for upToNextMajor