Fix issue where web sockets don't close on TLS connections

vapor / websocket-kit

WebSocket client library built on SwiftNIO

https://docs.vapor.codes/4.0/advanced/websockets/

MIT License

272 stars 79 forks source link

Fix issue where web sockets don't close on TLS connections #89

Closed EthanLozano closed 3 years ago

EthanLozano commented 3 years ago

Resolves an issue where web socket connections weren't being closed after being sent a close() from the client on TLS connections (#89). Resolves (#86)

lmcd commented 3 years ago

👍

lmcd commented 3 years ago

@0xTim - any progress with this review?

0xTim commented 3 years ago

@lmcd currently trying to write a failing test for it. If I can't get one done by tomorrow I'll just merge

EthanLozano commented 3 years ago

@0xTim I found the simplest way to reproduce the issue and commented on the issue's page. The issue is exposed when SSL is enabled. The current TLS test only has websocket-kit on the client-side, and I think you want a test where websocket-kit's source code is used on both the server and the client? idk.

VaporBot commented 3 years ago

These changes are now available in 2.1.3