search

vapor / websocket-kit

WebSocket client library built on SwiftNIO
https://docs.vapor.codes/4.0/advanced/websockets/
MIT License
272 stars 79 forks source link

Fix deprecation in `WebSocketClient` #99

Closed axtonpitt closed 3 years ago

axtonpitt commented 3 years ago

Fix TLSConfiguration.forClient() deprecation warning

warning: 'forClient(cipherSuites:minimumTLSVersion:maximumTLSVersion:certificateVerification:trustRoots:certificateChain:privateKey:applicationProtocols:shutdownTimeout:keyLogCallback:)' is deprecated: renamed to 'makeClientConfiguration()'
0xTim commented 3 years ago

@axtonpitt thanks for this! Can you bump the NIOSSL to .package(url: "https://github.com/apple/swift-nio-ssl.git", from: "2.14.0"), in Package.swift?

axtonpitt commented 3 years ago

@0xTim Cool done. I didn't understand what did you meant by "manifest" though?

0xTim commented 3 years ago

Sorry manifest == Package.swift!

0xTim commented 3 years ago

@axtonpitt I've fixed all the tests, can you update your branch so we can get CI green?

axtonpitt commented 3 years ago

@0xTim done

VaporBot commented 3 years ago

These changes are now available in 2.1.4