search

vapourismo / knx-go

KNX clients and protocol implementation in Go
MIT License
91 stars 59 forks source link

Implement DESCRIPTION_REQUEST #55

Closed theobarrague closed 2 years ago

theobarrague commented 2 years ago

I want to send a DESCRIPTION_REQUEST over IP Gateway. I can't find an implementation, did you implemented it ? If no, I can help

mobilarte commented 2 years ago

DESCRIPTION_REQUEST or DIAGNOSTIC_REQUEST are not implemented here. I have it on my todo list, but I have currently a pull request that needs to be fixed (Multicast behavior on Windows).

I have an experimental copy of this implementation with more DPTs, where I also rewrote the parsing of DIBs including DESCRIPTION_REQUESTs. It is available at knx-exp. Feel free to test it (it requires go 18.x because of typed parameters).

vapourismo commented 2 years ago

@mobilarte Want me to assign you this issue for tracking?

mobilarte commented 2 years ago

This will probably not be necessary. I have just added a PR for DESCRIPTION_REQUEST with a few cosmetic fixes. Thank you for reviewing.

vapourismo commented 2 years ago

This has been addressed in #56 thanks to @mobilarte.