vapoursynth / vsrepo

A simple package repository for VapourSynth
MIT License
106 stars 27 forks source link

vsrupdate.py can not update directly linked dlls #112

Closed theChaosCoder closed 5 years ago

theChaosCoder commented 5 years ago

Check this:

{
    "name": "Warpsharp",
    "type": "VSPlugin",
    "description": "Warpsharp floating point version",
    "github": "https://github.com/IFeelBloated/warpsharp",
    "doom9": "https://forum.doom9.org/showthread.php?t=176796",
    "category": "Other",
    "identifier": "com.zonked.awarpsharp2",
    "namespace": "warpsf",
    "releases": [
        {
            "version": "",
            "published": "",
            "win64": {
                "url": "https://github.com/IFeelBloated/warpsharp/releases/download/r1/warpsharpsf.dll",
                "files": {
                    "warpsharpsf.dll": [
                        "warpsharpsf.dll",
                        "hash"
                    ]
                }
            }
        }
    ]
}
myrsloik commented 5 years ago

Provide an error message or better description.

theChaosCoder commented 5 years ago

The "error" would be No win64 binary found. It seems vsrupdate can only handle zip/7z files. So the result is always like this with vsrupdate.py -p warpsf update-local -g <token>:

    "releases": [
        {
            "version": "r1",
            "published": "2019-08-24T10:38:33Z"
        },
        {
        ... 
        }
myrsloik commented 5 years ago

Yes, this is indeed unsupported but the answer is to compress releases like a sane person in my opinion.

theChaosCoder commented 5 years ago

In this case it does not save that much bandwidth: 28kb dll vs 15kb zip. I guess that means you won't add support for it?

myrsloik commented 5 years ago

No, definitely won't bother. It's actually a horrible idea not to compress because then normal users (not using vsrepo to automatically check file hash) won't realize if the download is corrupt.