varabyte / kobweb

A modern framework for full stack web apps in Kotlin, built upon Compose HTML
https://kobweb.varabyte.com
Apache License 2.0
1.53k stars 68 forks source link

Make nekt.compose.css enums consistent with WebCompose style #2

Closed bitspittle closed 3 years ago

bitspittle commented 3 years ago

Compare:

# web compose

interface DisplayStyle: StylePropertyEnum {
    companion object {
        inline val Block get() = DisplayStyle("block")
        inline val Inline get() = DisplayStyle("inline")
        ...
        inline val Initial get() = DisplayStyle("initial")
        inline val Unset get() = DisplayStyle("unset")
    }
}
# kobweb compose

enum class FontStyle(val value: String) {
    NORMAL("normal"),
    ITALIC("italic"),
}

We should match upstream style, especially we hope someday that maybe they'll implement the holes we're filling

bitspittle commented 3 years ago

I did this at some point