search

varabyte / kobweb

A modern framework for full stack web apps in Kotlin, built upon Compose HTML
https://kobweb.varabyte.com
Apache License 2.0
1.46k stars 65 forks source link

Consider removing revertlayer enums #215

Closed bitspittle closed 1 year ago

bitspittle commented 1 year ago

The revert-layer enum is a value associated with cascade layers, which Kobweb (and Compose for Web itself?) doesn't support.

I originally didn't add them because the C4W code doesn't have them, but after a while I started making an effort to copy JS APIs as the source of truth. I didn't really understand why or why not I should or should not include them, and simply thought the C4W codebase omitted them by accident.

But maybe it was on purpose actually?

It's probably worth revisiting this decision one more time before 1.0, because if I remove them, it slightly simplifies all CSS APIs just a tad, preventing people from picking an (as far as I can tell) useless feature. And we can always add them back in the future.

bitspittle commented 1 year ago

Removed.

Why provide an API for something that can never get used? That's my current thinking.