search

varabyte / kobweb

A modern framework for full stack web apps in Kotlin, built upon Compose HTML
https://kobweb.varabyte.com
Apache License 2.0
1.53k stars 68 forks source link

Add support for multiple box shadows on BoxShadow Modifier API #536

Closed rafaeltonholo closed 4 months ago

rafaeltonholo commented 4 months ago

Currently, the BoxShadow Modifier API only supports a single shadow. This PR enables the API to receive multiple shadows or none, in case the user wants to remove a shadow in a variant style.

rafaeltonholo commented 4 months ago

Looks great, and thanks for your patience on the back and forth.

I can tell by your attention to detail that wherever you work or whatever you work on is lucky to have you.

You may be interested to hear that the discussions we had here about the "CSS-" prefix has actually caused us to reflect on the pattern more broady in our codebase, and it seems likely that the way I designed CSSTransition and CSSAnimation is wrong.

Note

CSSAnimation comes from Compose HTML but they screwed up their implementation, which is originally what caused me to introduce a fixed version of it into Kobweb, but now we're thinking Animation.of is more Kobweb idiomatic.

I'm glad that I could help with the project! I really like its idea and I hope I can contribute more in the future :)