varabyte / kobweb

A modern framework for full stack web apps in Kotlin, built upon Compose HTML
https://kobweb.varabyte.com
Apache License 2.0
1.53k stars 68 forks source link

Remove redundant @Immutable / @Stable annotations after upstream Compose fix #554

Open bitspittle opened 3 months ago

bitspittle commented 3 months ago

JetBrains compose multiplatform introduced a pretty bad recomposition issue back in v1.6.0 that we just noticed recently. https://github.com/JetBrains/compose-multiplatform/issues/4967

As a result, we will audit the code right now, marking various interfaces / classes as @Immutable / @Stable as necessary, in order to prevent unnecessary recompositions from happening. However, annotating elements ourselves instead of letting the Compose compiler do it feels fragile and we'd like to remove them someday.