varabyte / kobweb

A modern framework for full stack web apps in Kotlin, built upon Compose HTML
https://kobweb.varabyte.com
Apache License 2.0
1.46k stars 65 forks source link

Update Kobweb to Kotlin 1.6.10 #80

Closed bitspittle closed 2 years ago

bitspittle commented 2 years ago

1.6.10 came out today (but we need to wait for Compose artifacts to catch up before we can upgrade)

Xaseron commented 2 years ago

https://github.com/JetBrains/compose-jb/releases/tag/v1.0.1 should be compatible with Kotlin 1.6.x

bitspittle commented 2 years ago

Thanks! I'll give that a shot today if I have time. :crossed_fingers:

bitspittle commented 2 years ago

Hmmm. With compose 1.0.1 and Kotlin 1.6.10, I'm getting:

e: This version (1.1.0-alpha06) of the Compose Compiler requires Kotlin version 1.5.31 but you appear to be using Kotlin version 1.6.10 which is not known to be compatible.  Please fix your configuration (or `suppressKotlinVersionCompatibilityCheck` but don't say I didn't warn you!).                                                   

I always hate this particular warning because I'm never quite sure where the compose compiler version is coming from. I'm guessing it's coming from the kotlin multiplatform plugin, but that's being set to 1.6.10, which is the latest at this time.


If you're curious to try this yourself, maybe double check I'm not missing a version upgrade, you can...

  1. clone kobweb
  2. edit gradle/libs.versions.toml, updating any relevant versions
  3. Go into kobweb/examples/helloworld and run /.gradlew compileKotlinJs
bitspittle commented 2 years ago

The error I was getting with my earlier comment was user error - I had a nested subproject which had its own dependency versions, so I had Kotlin 1.6.10 as the version of my multiplatform plugin in one place and 1.5.31 elsewhere.

Now with latest checked in, everything looks like it's compiling smoothly!