Added cluster metric of total scanned rows and users

varadaio / presto-workload-analyzer

The Workload Analyzer collects Presto® and Trino workload statistics, and analyzes them

GNU General Public License v3.0

135 stars 38 forks source link

Added cluster metric of total scanned rows and users #6

Closed sbernauer closed 3 years ago

sbernauer commented 3 years ago

Change is backward-compatible and will pick up existing queries. Screenshot after the change

Guy-Mast commented 3 years ago

@sbernauer thanks for your contribution! can you please squash the commits so will have just one commit in this PR?

sbernauer commented 3 years ago

Hi @Guy-Mast of course, did so

Guy-Mast commented 3 years ago

Hi @sbernauer, IMO breaking this sentence into two sentences will make it clearer to readers. We can do something like: The Workload Analyzer ran over a period of D days and analyzed Q queries that were executed by U users. During this period R rows and T TB of data were scanned.

WDYT?

sbernauer commented 3 years ago

LGTM, i will adopt the PR

sbernauer commented 3 years ago

Is this fine?