search

varadpoddar / MB-System

MB-System is an open source software package for the processing and display of bathymetry and backscatter imagery data derived from multibeam, interferometry, and sidescan sonars.
https://www.mbari.org/products/research-software/mb-system/
Other
0 stars 0 forks source link

Filter the draco folder files to only include the ones we need #2

Closed varadpoddar closed 3 weeks ago

varadpoddar commented 7 months ago

Hinderance The current infrastructure is aimed at loading the google/draco , syoyo/tinygltf from static folders within the mbgrd2gltf folder. This makes it tedious to upgrade the dependencies.

Prospective Solution We can use git submodules and sparse-checkout to make it programmatically easier to update these dependencies for current and future use.

Alternatives Leave the current process alone and update dependencies as required.

Tasks

- [ ] Add git-submodule for draco - [ ] sparse-checkout draco/src/draco/{attributes,compression,core,mesh,metadata,point_cloud,texture} Folders + draco_features.h + draco license - [ ] Add git-submodule for tinyGLTF - [ ] sparse-checkout specific files for tinyGLTF + license

Edit: We are going to stick with the same structure and drop in the required files. New tasks include :

MBARIMike commented 7 months ago

In the spirit of the MB-System project I think it's fine to leave the current process alone and update dependencies as required.

varadpoddar commented 7 months ago

Thanks @MBARIMike, I have updated the description.

@IvanMart57 Would you be able to take a look at this and see of you can filter through and remove the unnecessary files ?

Blue Pill : A simple way would be to remove the files and introduce them one by one based on the include errors.

Red Pill : A sophisticated way would be to use a dependency checker utility that would be able to sniff out the dependencies for draco/encode.h and list the dependent files.

Thank You

varadpoddar commented 3 weeks ago

This was partially fixed in commit 26c3858090eba1c2a4e44885b28a6ee212dd70c5 using BluePill method along with using built in Draco binaries if installed. Marking Closed.