search

varchar-io / nebula

A distributed block-based data storage and compute engine
https://nebula.bz
Apache License 2.0
154 stars 18 forks source link

[Feature] Support bounded time slice in timeline query #180

Closed shawncao closed 2 years ago

shawncao commented 2 years ago

(Context, this is how the current timeline works) The timeline query will have 3 basic inputs: start time, end time, and window size, simply it just slices the whole time range into pieces according to the window size.

For general timeline, this works great as long as the window size is flexible, but there are real business scenarios that they want the timeline to fit into the boundaries of a given unit, such as Weekly, Monthly, Quarterly, or Yearly.

In these cases, data needs to fit into the boundary of the time unit, and should not cross multiple different units.

The change should be simple in the query building/planning phase, but need to introduce a new interface and enough tests.

(Suggestion: A good starting task for new committer.)

caoash commented 2 years ago

(Closed?) by https://github.com/varchar-io/nebula/pull/182

shawncao commented 2 years ago

happily to close it, @caoash Just a tip - next time, you can associate the Issue with your PR, so that it will automatically close the issue when the PR is completed.

caoash commented 2 years ago

Got it, thanks