search

varchar-io / nebula

A distributed block-based data storage and compute engine
https://nebula.bz
Apache License 2.0
154 stars 18 forks source link

Setup Github Action #9

Open shawncao opened 4 years ago

shawncao commented 4 years ago

Set up Github Action to build Nebula nightly.

Right now, to make the nebula build work (Ubuntu) on a fresh machine, it is not EASY! @samprasyork probably had a great feeling about it, :)

This issue is to track let's make the build experience easy for future developers on this project. Github Action supports cmake based project, by enabling it, I guess we will fix most of the build issues.

samprasyork commented 4 years ago

I am crying everyday.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Shawn Cao notifications@github.com Sent: Wednesday, October 28, 2020 4:53:43 PM To: shawncao/nebula nebula@noreply.github.com Cc: samprasyork samprasyork@hotmail.com; Mention mention@noreply.github.com Subject: [shawncao/nebula] Setup Github Action (#9)

Set up Github Action to build Nebula nightly.

Right now, to make the nebula build work (Ubuntu) on a fresh machine, it is not EASY! @samprasyorkhttps://github.com/samprasyork probably had a great feeling about it, :)

This issue is to track let's make the build experience easy for future developers on this project. Github Action supports cmake based project, by enabling it, I guess we will fix most of the build issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/shawncao/nebula/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABWB37ZYDLZO6GBZEW7HHN3SNCVIPANCNFSM4TDALX3A.

samprasyork commented 4 years ago

Can we add script into Make file? Like after make, run the necessary command to install

Get Outlook for iOShttps://aka.ms/o0ukef

From: FENG YU samprasyork@hotmail.com Sent: Wednesday, October 28, 2020 4:54:43 PM To: shawncao/nebula reply@reply.github.com; shawncao/nebula nebula@noreply.github.com Cc: Mention mention@noreply.github.com Subject: Re: [shawncao/nebula] Setup Github Action (#9)

I am crying everyday.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Shawn Cao notifications@github.com Sent: Wednesday, October 28, 2020 4:53:43 PM To: shawncao/nebula nebula@noreply.github.com Cc: samprasyork samprasyork@hotmail.com; Mention mention@noreply.github.com Subject: [shawncao/nebula] Setup Github Action (#9)

Set up Github Action to build Nebula nightly.

Right now, to make the nebula build work (Ubuntu) on a fresh machine, it is not EASY! @samprasyorkhttps://github.com/samprasyork probably had a great feeling about it, :)

This issue is to track let's make the build experience easy for future developers on this project. Github Action supports cmake based project, by enabling it, I guess we will fix most of the build issues.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/shawncao/nebula/issues/9, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABWB37ZYDLZO6GBZEW7HHN3SNCVIPANCNFSM4TDALX3A.

shawncao commented 4 years ago

I think the best way is to remove all manual installation steps from our ext/*.cmake

Instead, we should use script to automate them like you said, use external code build as much as possible, and then if some of the projects not available with code build, we can also use cmake command API to execute scripts to install.

I think as long as we can make Github Action work, it should fix most of the building issues we have seen so far, :)

@hukid actually makes the build succeed in much shorter time, maybe he is a luckier person, haha

samprasyork commented 4 years ago

He prays everyday, that might be why. I am going to do so.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Shawn Cao notifications@github.com Sent: Wednesday, October 28, 2020 5:01:05 PM To: shawncao/nebula nebula@noreply.github.com Cc: samprasyork samprasyork@hotmail.com; Mention mention@noreply.github.com Subject: Re: [shawncao/nebula] Setup Github Action (#9)

I think the best way is to remove all manual installation steps from our ext/*.cmake

Instead, we should use script to automate them like you said, use external code build as much as possible, and then if some of the projects not available with code build, we can also use cmake command API to execute scripts to install.

I think as long as we can make Github Action work, it should fix most of the building issues we have seen so far, :)

@hukidhttps://github.com/hukid actually makes the build succeed in much shorter time, maybe he is a luckier person, haha

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/shawncao/nebula/issues/9#issuecomment-718275750, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABWB373M7O3IQR2ERCD5Y3TSNCWEDANCNFSM4TDALX3A.

shawncao commented 4 years ago

Let's do it - pray really helps! :)