search

vardius / gorouter

Go Server/API micro framework, HTTP request router, multiplexer, mux
https://rafallorenz.com/gorouter
MIT License
154 stars 17 forks source link

add tests for case return node matching reference vs return new node on matched reference #19

Closed mar1n3r0 closed 4 years ago

mar1n3r0 commented 4 years ago

add tests demonstrating the issue when returning matched node reference instead of returning new node on matched reference

codecov[bot] commented 4 years ago

Codecov Report

Merging #19 into hotfix/middleware-by-path will decrease coverage by 0.68%. The diff coverage is 0%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           hotfix/middleware-by-path      #19      +/-   ##
=============================================================
- Coverage                      71.26%   70.57%   -0.69%     
=============================================================
  Files                             10       10              
  Lines                            515      520       +5     
=============================================================
  Hits                             367      367              
- Misses                           134      139       +5     
  Partials                          14       14
Impacted Files Coverage Δ
mux/tree.go 32.78% <0%> (-1.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e898a77...2535929. Read the comment docs.

mar1n3r0 commented 4 years ago

Yeps sorry my bad, closing that one.