search

vardius / gorouter

Go Server/API micro framework, HTTP request router, multiplexer, mux
https://rafallorenz.com/gorouter
MIT License
154 stars 17 forks source link

Reverse order of middleware slice when adding orphan node. #22

Closed mar1n3r0 closed 4 years ago

mar1n3r0 commented 4 years ago

Add notes to docs that middleware is defined descending broader to specific and wildcard to static.

codecov[bot] commented 4 years ago

Codecov Report

Merging #22 into hotfix/middleware-by-path will increase coverage by 0.31%. The diff coverage is 100%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           hotfix/middleware-by-path      #22      +/-   ##
=============================================================
+ Coverage                      71.59%   71.91%   +0.31%     
=============================================================
  Files                             10       10              
  Lines                            528      534       +6     
=============================================================
+ Hits                             378      384       +6     
  Misses                           135      135              
  Partials                          15       15
Impacted Files Coverage Δ
mux/tree.go 37.69% <ø> (ø) :arrow_up:
middleware/middleware.go 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c571661...59e48ed. Read the comment docs.

mar1n3r0 commented 4 years ago

Closing this as we figured out reverse is not an option.