varemenos / obscurity-syntax

Obscurity is a dark syntax theme for Atom
https://atom.io/themes/obscurity-syntax
MIT License
0 stars 1 forks source link

upgrade selectors to get rid of deprecation warnings #1

Open rcrooks opened 6 years ago

rcrooks commented 6 years ago

Hi @varemenos I'm very fond of this syntax theme, but I do wish you could update the selectors so that all those deprecation warnings stop appearing. Actually, if you accept pull requests, I'd be happy to do it.

Here are the deprecation warnings; obscurity-syntax/index.less Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor, :host => atom-text-editor,atom-text-editor atom-text-editor .wrap-guide, :host .wrap-guide => atom-text-editor .wrap-guide,atom-text-editor .wrap-guide atom-text-editor .indent-guide, :host .indent-guide => atom-text-editor .indent-guide,atom-text-editor .indent-guide atom-text-editor .invisible-character, :host .invisible-character => atom-text-editor .invisible-character,atom-text-editor .invisible-character atom-text-editor .gutter, :host .gutter => atom-text-editor .gutter,atom-text-editor .gutter atom-text-editor .gutter .line-number.cursor-line, :host .gutter .line-number.cursor-line => atom-text-editor .gutter .line-number.cursor-line,atom-text-editor .gutter .line-number.cursor-line atom-text-editor .gutter .line-number.cursor-line-no-selection, :host .gutter .line-number.cursor-line-no-selection => atom-text-editor .gutter .line-number.cursor-line-no-selection,atom-text-editor .gutter .line-number.cursor-line-no-selection atom-text-editor .gutter .line-number.folded, :host .gutter .line-number.folded, atom-text-editor .gutter .line-number:after, :host .gutter .line-number:after, atom-text-editor .fold-marker:after, :host .fold-marker:after => atom-text-editor .gutter .line-number.folded,atom-text-editor .gutter .line-number.folded, atom-text-editor .gutter .line-number:after,atom-text-editor .gutter .line-number:after, atom-text-editor .fold-marker:after,atom-text-editor .fold-marker:after atom-text-editor .invisible, :host .invisible => atom-text-editor .invisible,atom-text-editor .invisible atom-text-editor .cursor, :host .cursor => atom-text-editor .cursor,atom-text-editor .cursor atom-text-editor .selection .region, :host .selection .region => atom-text-editor .selection .region,atom-text-editor .selection .region atom-text-editor .search-results .marker .region, :host .search-results .marker .region => atom-text-editor .search-results .syntax--marker .region,atom-text-editor .search-results .syntax--marker .region atom-text-editor .search-results .marker.current-result .region, :host .search-results .marker.current-result .region => atom-text-editor .search-results .syntax--marker.current-result .region,atom-text-editor .search-results .syntax--marker.current-result .region .comment => .syntax--comment .entity.name.type => .syntax--entity.syntax--name.syntax--type .entity.other.inherited-class => .syntax--entity.syntax--other.syntax--inherited-class .keyword => .syntax--keyword .keyword.control => .syntax--keyword.syntax--control .keyword.operator => .syntax--keyword.syntax--operator .keyword.other.special-method => .syntax--keyword.syntax--other.syntax--special-method .keyword.other.unit => .syntax--keyword.syntax--other.syntax--unit .storage => .syntax--storage .storage.todo => .syntax--storage.syntax--todo .constant => .syntax--constant .constant.character.escape => .syntax--constant.syntax--character.syntax--escape .constant.numeric => .syntax--constant.syntax--numeric .constant.other.color => .syntax--constant.syntax--other.syntax--color .constant.other.symbol => .syntax--constant.syntax--other.syntax--symbol .variable => .syntax--variable .variable.interpolation => .syntax--variable.syntax--interpolation .variable.parameter.function => .syntax--variable.syntax--parameter.syntax--function .invalid.illegal => .syntax--invalid.syntax--illegal .string => .syntax--string .string.regexp => .syntax--string.syntax--regexp .string.regexp .source.ruby.embedded => .syntax--string.syntax--regexp .syntax--source.syntax--ruby.syntax--embedded .string.other.link => .syntax--string.syntax--other.syntax--link .punctuation.definition.comment => .syntax--punctuation.syntax--definition.syntax--comment .punctuation.definition.string, .punctuation.definition.variable, .punctuation.definition.parameters, .punctuation.definition.array => .syntax--punctuation.syntax--definition.syntax--string, .syntax--punctuation.syntax--definition.syntax--variable, .syntax--punctuation.syntax--definition.syntax--parameters, .syntax--punctuation.syntax--definition.syntax--array .punctuation.definition.heading, .punctuation.definition.identity => .syntax--punctuation.syntax--definition.syntax--heading, .syntax--punctuation.syntax--definition.syntax--identity .punctuation.definition.bold => .syntax--punctuation.syntax--definition.syntax--bold .punctuation.definition.italic => .syntax--punctuation.syntax--definition.syntax--italic .punctuation.section.embedded => .syntax--punctuation.syntax--section.syntax--embedded .support.class => .syntax--support.syntax--class .support.function => .syntax--support.syntax--function .support.function.any-method => .syntax--support.syntax--function.syntax--any-method .entity.name.function => .syntax--entity.syntax--name.syntax--function .entity.name.class, .entity.name.type.class => .syntax--entity.syntax--name.syntax--class, .syntax--entity.syntax--name.syntax--type.syntax--class .entity.name.section => .syntax--entity.syntax--name.syntax--section .entity.name.tag => .syntax--entity.syntax--name.syntax--tag .entity.other.attribute-name => .syntax--entity.syntax--other.syntax--attribute-name .entity.other.attribute-name.id => .syntax--entity.syntax--other.syntax--attribute-name.syntax--id .meta.class => .syntax--meta.syntax--class .meta.link => .syntax--meta.syntax--link .meta.require => .syntax--meta.syntax--require .meta.selector => .syntax--meta.syntax--selector .meta.separator => .syntax--meta.syntax--separator .none => .syntax--none .markup.bold => .syntax--markup.syntax--bold .markup.changed => .syntax--markup.syntax--changed .markup.deleted => .syntax--markup.syntax--deleted .markup.italic => .syntax--markup.syntax--italic .markup.heading .punctuation.definition.heading => .syntax--markup.syntax--heading .syntax--punctuation.syntax--definition.syntax--heading .markup.inserted => .syntax--markup.syntax--inserted .markup.list => .syntax--markup.syntax--list .markup.quote => .syntax--markup.syntax--quote .markup.raw.inline => .syntax--markup.syntax--raw.syntax--inline .source.gfm .markup => .syntax--source.syntax--gfm .syntax--markup .source.gfm .markup.heading => .syntax--source.syntax--gfm .syntax--markup.syntax--heading atom-text-editor[mini] .scroll-view, :host([mini]) .scroll-view => atom-text-editor[mini] .scroll-view,atom-text-editor .scroll-view .meta.structure.dictionary.value.json .punctuation + .string.quoted.double.json => .syntax--meta.syntax--structure.syntax--dictionary.syntax--value.syntax--json .syntax--punctuation + .syntax--string.syntax--quoted.syntax--double.syntax--json .meta.structure.dictionary.value.json .constant.numeric.json => .syntax--meta.syntax--structure.syntax--dictionary.syntax--value.syntax--json .syntax--constant.syntax--numeric.syntax--json .css.entity.pseudo-element => .syntax--css.syntax--entity.syntax--pseudo-element

varemenos commented 6 years ago

Hi @rcrooks, I haven't used or supported this syntax theme for a very long time but if you feel like contributing I would be more than happy to accept PRs or even make you a collaborator.

rcrooks commented 6 years ago

great; I'll send you a PR when I get it done