search

varenius / salsa

Code developed for the 2.3m radio telescopes SALSA in Onsala, Sweden
MIT License
16 stars 6 forks source link

Added some files and a little change #31

Closed mirsakhawathossain closed 7 years ago

mirsakhawathossain commented 7 years ago

I have added some Python files and a style change for analysis and good looking both. So please merge these.

varenius commented 7 years ago

We already have example data files in the repo, more FITS data is not needed here.

The minor cosmetic changes to the readme is nice but not necessary.

Regarding Python analysis: There are already python templates for how to process SALSA data described in the "User Manual Sect. 2.5.4", linked to https://github.com/molberg/salsa. You script is mostly a copy-paste of this script, and hence does not add any functionality. The example scripts maintained my the molberg-account are written by a staff astronomer at the Onsala Space Observatory. He has deep knowledge of SALSA and is also able to modify them in the future in case things change.

A general comment: We don't need python scripts to process SALSA data on the level of scripts. What we need is either refinements to the current control program, such as improving the plotting speed of the internal figures, or replacement of the SALSAJ software in python. Before adding code, take a look at the "issue queue" regarding what is needed in terms of development.