search

varenius / salsa

Code developed for the 2.3m radio telescopes SALSA in Onsala, Sweden
MIT License
16 stars 6 forks source link

Language change gives position error message #77

Open maltesk opened 2 years ago

maltesk commented 2 years ago

Describe the bug Sometimes changing the language sends up an irrelevant position error message

To Reproduce Simple tab Go to satellite C05, take a measurement Change language UI language changes. The UI shows the wrong position (Galactic 140 when I tried). An error box is shown reporting an invalid position request. When I click OK on the error message, the UI goes back to normal. Not sure if this happens every time.

Expected behavior UI language changes

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): Windows 10, Chrome 97.0.4692.99

Additional context Both brage and torre

varenius commented 2 years ago

I cannot reproduce this. But I have a hunch what I could be. I'll make a fix and we can see if you can reproduce it again?

varenius commented 2 years ago

Maybe this could possibly be due to the UI time trying to update the UI during the language changing sequence. It could explain why it's not always reproducible. Anyway, pausing the time during the changing sequence should avoid this. Maybe @maltesk could check if the problem is gone now?

maltesk commented 2 years ago

Reproduced 2 out of 3 attempts with torre, observing satellite C05 and the Sun.

varenius commented 2 years ago

Weird. I tried to replicate this 30 times without a single error. I think that somehow we do something slightly different. I think you will have to show me, so I can watch exactly how you make the error happen. Maybe it's a timing issue, where we click things in different sequence timing or order.

maltesk commented 2 years ago

Now not reproduced on torre.