Closed tedil closed 6 months ago
Attention: Patch coverage is 83.33333%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 87.42%. Comparing base (
721d606
) to head (2b08951
).
Thanks a lot. This generally looks good. How much performance impact are you seeing in a test case?
Running benches/translate_cds.rs (target/release/deps/translate_cds-c57b7f59d5053bc8)
translate_cds TTN time: [153.05 µs 153.31 µs 153.61 µs]
Found 14 outliers among 100 measurements (14.00%)
5 (5.00%) high mild
9 (9.00%) high severe
Running benches/translate_cds.rs (target/release/deps/translate_cds-41f293dcbeaaadcb)
translate_cds TTN time: [120.43 µs 121.08 µs 121.87 µs]
change: [-20.521% -19.639% -18.312%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) high mild
8 (8.00%) high severe
[u8; 3]
instead ofVec
, i.e. stack vs heap&c[..3]
instead ofiter().take(3)
(even though that should not really have made a difference, but according to criterion, seemed to be the case)