varfish-org / hgvs-rs

A port of biocommons/hgvs to the Rust programming language
Apache License 2.0
11 stars 4 forks source link

fix: do not report deleted or duplicated reference in hgvs.c notation #199

Closed tedil closed 1 month ago

tedil commented 1 month ago

See https://hgvs-nomenclature.org/stable/background/simple/ (especially "sometimes misreported as" comments)

holtgrewe commented 1 month ago

Hm, this is what NoRef<> is for.

https://github.com/varfish-org/hgvs-rs/blob/ed9617def27fb2e740a5b3e1b89caf6813d505f7/src/parser/display.rs#L11

tedil commented 1 month ago

Hm, this is what NoRef<> is for.

https://github.com/varfish-org/hgvs-rs/blob/ed9617def27fb2e740a5b3e1b89caf6813d505f7/src/parser/display.rs#L11

ah okay, then we'd better use that

tedil commented 1 month ago

Not needed, simply use NoRef newtype in mehari