search

varfish-org / varfish-server-worker

Rust-based background worker for varfish-server
MIT License
2 stars 1 forks source link

refactor!: adjusting max_af to max_carriers for inhouse #512

Closed holtgrewe closed 4 weeks ago

holtgrewe commented 4 weeks ago

Release-As: 0.16.0

Summary by CodeRabbit

coderabbitai[bot] commented 4 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the query.proto file and the corresponding Rust implementation in query.rs. A new message, InhouseFrequencySettings, has been introduced to define in-house frequency settings, replacing the previous NuclearFrequencySettings in the QuerySettingsFrequency message. Additionally, comments in the proto file have been updated for clarity. The Rust struct has been updated to match these changes, and test cases have been adjusted to ensure functionality aligns with the new definitions.

Changes

File Path Change Summary
protos/varfish/v1/seqvars/query.proto - Added new message: InhouseFrequencySettings.
- Updated QuerySettingsFrequency to use InhouseFrequencySettings instead of NuclearFrequencySettings.
- Comments modified for clarity.
src/seqvars/query/schema/query.rs - Added new struct: InhouseFrequencySettings.
- Updated QuerySettingsFrequency to use InhouseFrequencySettings.
- Modified conversion logic for InhouseFrequencySettings.
- Updated test cases for compatibility with new structures.

Poem

🐇 In the meadow where changes bloom,
New settings sprout, dispelling gloom.
Inhouse filters now take flight,
With maximum counts shining bright.
A hop, a skip, a proto cheer,
Clarity reigns, the path is clear! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71%. Comparing base (06ebb8a) to head (c54f463). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #512 +/- ## ===================================== Coverage 71% 71% ===================================== Files 43 43 Lines 11831 11841 +10 ===================================== + Hits 8501 8511 +10 Misses 3330 3330 ``` | [Files with missing lines](https://app.codecov.io/gh/varfish-org/varfish-server-worker/pull/512?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=varfish-org) | Coverage Δ | | |---|---|---| | [src/seqvars/query/schema/query.rs](https://app.codecov.io/gh/varfish-org/varfish-server-worker/pull/512?src=pr&el=tree&filepath=src%2Fseqvars%2Fquery%2Fschema%2Fquery.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=varfish-org#diff-c3JjL3NlcXZhcnMvcXVlcnkvc2NoZW1hL3F1ZXJ5LnJz) | `97% <100%> (+<1%)` | :arrow_up: |