varfish-org / varfish-server

VarFish: comprehensive DNA variant analysis for diagnostics and research
MIT License
43 stars 11 forks source link

hemizygous count is not displayed in varfish variant detail #1836

Closed xiamaz closed 2 months ago

xiamaz commented 2 months ago

Describe the bug For X-chromosomal variants the number of hemizygous individuals is not displayed in the variant details.

To Reproduce Steps to reproduce the behavior:

  1. Filter for X-chromosomal variants.
  2. Click on any variant result

Expected behavior For X-chromosomal variants the count of heterozygous, hemizygous and homozygous individuals should be shown.

xiamaz commented 2 months ago

Workaround

Using the gnomAD linkout the number of hemizygous individuals can be directly seen on the official webpage.

stolpeo commented 2 months ago

@xiamaz On their website, gnomAD does not list heterozygotes. Is such a column really required?

On another note, I noticed that by default gnomAD exome and genome counts are added to a single number per population on their website by default. One can remove the counts from one or the other via a checkbox. I wondered if it would make the frequency information simpler by providing a combined count as well.

stolpeo commented 2 months ago

annonars currently does not return this number: https://github.com/varfish-org/annonars/issues/506

stolpeo commented 2 months ago

@xiamaz I had a conversation with @holtgrewe who mentioned that the number of homozygotes in males equals the number of hemizygotes in the X chromosome. Would that information be sufficient?

xiamaz commented 2 months ago

How would you implement that? I'm unsure I can follow

holtgrewe commented 2 months ago

@xiamaz outside of PAR, the number of XY carriers equal the number of hemizygous carriers

xiamaz commented 2 months ago

Outside PAR this is correct.

stolpeo commented 2 months ago

Sorry I didn't indicate my intention. I was to ask if the information is sufficient so I don't implement anything. I don't know how important the number for the PAR region is.

holtgrewe commented 2 months ago

@xiamaz inside the PAR, things are as follows:

xiamaz commented 2 months ago

In the user interface please explicitly list the count of hemizygous cases. Whether the gene is inside or outside of PAR is easy to forget for an investigator and takes too much mental bandwidth.

stolpeo commented 2 months ago

OK we then need to complete https://github.com/varfish-org/annonars/issues/506 first. Is the information available somewhere whether the variant lies within a PAR or not and if so, would it be valuable to also display this information?

holtgrewe commented 2 months ago

Specification

Overall, we should correspond to gnomAD

xiamaz commented 2 months ago

Discussion with @stolpeo:

@xiamaz I see issues with reimplementing this logic in VarFish, as these counts are already available in the gnomAD data and can just be passed through. @tedil How much work is it to extend annonars to support hemizygous counts? If this is too much work, we should consider the alternative workaround.

tedil commented 2 months ago

About this ↑ much work to include the respective fields in the data sources -- for gnomad2 SV only, that is. Not sure what has to happen downstream from that, though.

holtgrewe commented 2 months ago

@xiamaz could you please explain why you assume the "hemi" data is in gnomAD?

Proof me wrong but

tedil commented 2 months ago

@xiamaz could you please explain why you assume the "hemi" data is in gnomAD?

Proof me wrong but

* gnomad has info on AC AN AF and nhomalt counts overall and for male/female XY/XX individuals only

* they compute the hemi counts on their website

Correct, the hemizygous counts and freqs are only specified in the gnomAD_SV datasets.

stolpeo commented 2 months ago

I also assumed that the data is in gnomAD because it is used on their website. However, here is the statement that they do not include the hemizygot counts anymore: https://gnomad.broadinstitute.org/news/2018-10-gnomad-v2-1/#hemizygote-counts

Hemizygote counts

For this release, there are no more hemizygote count annotations. Instead, our male counts correctly consider males as hemizygous in non-pseudo-autosomal (non-PAR) regions of the sex chromosomes and we provide a nonpar flag to identify all variants that are in the these regions.

xiamaz commented 2 months ago

In that case doing this conversion is the best way. 👍