search

varianter / variant-rocks

GPT chat UI internal for Variant
https://variant.rocks
MIT License
5 stars 0 forks source link

EmployeeCard #1

Closed TrymVei closed 1 year ago

TrymVei commented 1 year ago

Component for employeeCard

Design: Screenshot 2023-08-18 at 08 49 15

Component: Screenshot 2023-08-18 at 08 52 47

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-rocks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 18, 2023 8:20am
christinaroise commented 1 year ago

Unsure of the practice here, but would love to see screenshots of both design/figma and component in the PR description. Makes it that much easier get caught up ✨

TrymVei commented 1 year ago

Unsure of the practice here, but would love to see screenshots of both design/figma and component in the PR description. Makes it that much easier get caught up ✨

Good idea. Will update the description

christinaroise commented 1 year ago

I'm being picky here. 😅 But did you also test on different screen sizes? What's the layout for mobile screens?

Edit: Is there any truncation of long names ex?

TrymVei commented 1 year ago

I'm being picky here. 😅 But did you also test on different screen sizes? What's the layout for mobile screens?

Edit: Is there any truncation of long names ex?

The max width of the div will fit on screens larger then 320px. Thinking about having flex column when the screen get smaller. Screenshot 2023-08-18 at 09 00 43