search

varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.2k stars 143 forks source link

URL changes needed for upgraded Wallhaven site #180

Closed netsnipe closed 5 years ago

netsnipe commented 5 years ago

All previous https://alpha.wallhaven.cc links are now dead and the site has switched over to a hash based naming scheme for their images.

For example, https://alpha.wallhaven.cc/wallpaper/775318 is now https://wallhaven.cc/w/dgegxl instead on the upgraded website.

A full list of changes can be found at:

and they've also implemented a new API which might be helpful.

nlpsuge commented 5 years ago

+1.

Please update.

compuerman2004 commented 5 years ago

goto /usr/lib/python3/dist-packages/variety edit as administrator wallhavendownloader.py delete the word alpha save restart variety goto variety preferences edit each wallhaven entry you should now get an ok now you should be able to add new entries

wallhaven could have used a dns pointer to fix this

nlpsuge commented 5 years ago

@compuerman2004 Thank you for your workaround. It should be WallhavenDownloader.py actually. 'Delete the word alpha' can fix this issue, and Variety can download images from wallhaven.cc now. But when I click 'View at wallhaven.cc' nothing happens. Any advice?

jlu5 commented 5 years ago

I've updated the API URL in the commit above.

For those with older images in their collection, "View at wallhaven.cc" is likely broken because Wallhaven changed their URL format without leaving redirects: see https://wallhaven.cc/forums/thread/1931. Opening the link works for me with newly downloaded images.

nlpsuge commented 5 years ago

@jlu5 But I cannot open the link with newly downloaded images...

jlu5 commented 5 years ago

Does a browser open at all when you click it?

compuerman2004 commented 5 years ago

yes there is nothing you can do except complain to wallhaven they changed from numeric only to alpha numeric file names. I have thousands of their pics I can't look up

wallhaven-nkkk6n.jpg used to be walhaven-4815.jpg Goodluck Rod

On Fri, Jun 7, 2019 at 12:24 AM nlpsuge notifications@github.com wrote:

@compuerman2004 https://github.com/compuerman2004 Thank you for your workaround. It should be WallhavenDownloader.py actually. 'Delete the word alpha' can fix this issue, and Variety can download images from wallhaven.cc now. But when I click 'View at wallhaven.cc' nothing happens. Any advice?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/varietywalls/variety/issues/180?email_source=notifications&email_token=AMHHQBBYZ6Z2B4SDAJVIMN3PZH5INA5CNFSM4HQMEMB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXE6V3Y#issuecomment-499772143, or mute the thread https://github.com/notifications/unsubscribe-auth/AMHHQBA4U5KFN4KQZE6J6BTPZH5INANCNFSM4HQMEMBQ .

nlpsuge commented 5 years ago

Does a browser open at all when you click it?

@jlu5 Nope. No browser was opened when I click 'View at Wallhaven.cc'.

Attention: What I clicked is a new picture downloaded from wallhaven.cc.

jlu5 commented 5 years ago

@nlpsuge Can you attach your ~/.config/variety/variety.log? It could be that Python's webbrowser module isn't functional on your machine for whatever reason...

You can test it locally by running something like

python3 -m webbrowser -t "http://www.python.org"

on a command line.

nlpsuge commented 5 years ago

@jlu5 I'v addressed the issue of my case. See this one: https://github.com/rofl0r/proxychains-ng/issues/287.

jlu5 commented 5 years ago

OK, I think I'll close this then since it's fixed in Git master.