Feature parity between get_wallpaper and set_wallpaper

varietywalls / variety

Wallpaper downloader and manager for Linux systems

http://peterlevi.com/variety

GNU General Public License v3.0

1.16k stars 140 forks source link

Feature parity between get_wallpaper and set_wallpaper #19

Open jlu5 opened 6 years ago

jlu5 commented 6 years ago

Right now get_wallpaper only supports a subset of DEs, and falls back to searching for a GNOME wallpaper even when this isn't correct (#175). We should aim for feature parity between these scripts.

Currently only supported in set_wallpaper:

[x] KDE Plasma 5 56e490746f3308018768866ad5798835083d3c49
[ ] Enlightenment / Moksha
[ ] Deepin
[ ] i3, openbox, dwm via feh / nitrogen (we should make the detection code smarter)

shirishag75 commented 6 years ago

shouldn't mate be also added to the list, uses gtk+ bindings so any support to mate means its automatically supported to GNOME also more or less.

jlu5 commented 6 years ago

@shirishag75 MATE is already supported in both scripts, this issue is for listing the DEs supported in set_wallpaper but not get_wallpaper.

https://github.com/varietywalls/variety/blob/master/data/scripts/get_wallpaper#L29-L31 https://github.com/varietywalls/variety/blob/master/data/scripts/set_wallpaper#L212-L213

dreaddr commented 3 years ago

Is this what is causing Deepin to not set the wallpaper?