varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.2k stars 143 forks source link

Memory Leak #32

Open ksrikanthcnc opened 6 years ago

ksrikanthcnc commented 6 years ago

Variety steadily is occupying more and more memory. It reached about 600MB before I killed it and restarted it.

ksrikanthcnc commented 6 years ago

On version 0.6.9, the problem persists (400MB)

jlu5 commented 6 years ago

(these issues are generally quite hard to debug since I can't reproduce them myself)

What desktop environment and wallpaper sources do you have enabled? Are you using any effects?

ksrikanthcnc commented 6 years ago

I'm using Ubuntu 16.04 Other than favourites,fetched and a folder (change every 15 minutes, download every 1 minute) image Effects: Keep original Quotes(default options except to change every 15minutes) Clock(default options)

ksrikanthcnc commented 6 years ago

it reached 832MB same settings as above added a few wallhaven sources

log file: variety.txt

variety.log too is being corrupted (the whole file gets converted to non-characters, and logging continues from second line, seen in vscode, gedit couldnt open the file ) when using shortcut to go to next image

peterlevi commented 6 years ago

It would be good to try to localize a bit the culprit. Please try turning off "Keep original" (it is not needed when you have no other effects selected), then monitor again memory usage for some time. Then try turning off clock and monitor again usage. Then turn off quotes and monitor usage. Hopefully it'll help us pinpoint the feature or part of the code that is causing the memory leak.

pabloab commented 1 year ago

Not sure if related to this issue, but I found variety (0.8.5) to be one of the most memory consuming process, measured with ps_mem (sudo ./ps_mem.py | tail -$(tput lines)) reaching around 90 MB.

Lot of logs on journalctl, but almost all related to FileNotFoundError: [Errno 2] No such file or directory: ' .... wallhaven_nature/wallhaven-ysl8fk.jpg.metadata. and safe_unlink() 'Could not delete