search

varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.2k stars 143 forks source link

Wallhaven search not properly handled #395

Open changemenemo opened 3 years ago

changemenemo commented 3 years ago

Version of Variety

0.8.4 under fedora 33

Describe the bug

I ve put a link in the text box which were resulted with 5000 hits on the website. Variety is only switching between 2 wallpaper 

INFO: 2020-11-14 11:12:41,614: download_one() 'Wallhaven.cc: Queue size: 0'
INFO: 2020-11-14 11:12:41,614: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-11-14 11:12:41,614: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'
INFO: 2020-11-14 11:12:41,614: download_one() 'Wallhaven.cc: Filling queue'
INFO: 2020-11-14 11:12:41,614: search() 'Performing wallhaven search: url=https://wallhaven.cc/search?q=id%3A479&categories=110&purity=100&sorting=relevance&order=desc'

Context

It does happen with every search and it does happen with keywords too

Attach Variety's log file

INFO: 2020-11-14 11:12:41,614: download_one() 'Wallhaven.cc: Queue size: 0'
INFO: 2020-11-14 11:12:41,614: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-11-14 11:12:41,614: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'
INFO: 2020-11-14 11:12:41,614: download_one() 'Wallhaven.cc: Filling queue'
INFO: 2020-11-14 11:12:41,614: search() 'Performing wallhaven search: url=https://wallhaven.cc/search?q=id%3A479&categories=110&purity=100&sorting=relevance&order=desc'

Desktop environment and version

gnome 3.38

OS name and version

fedora 33 workstation

Screenshots

Attached files

Additional context

changemenemo commented 3 years ago 
INFO: 2020-11-14 11:24:26,507: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-11-14 11:24:26,507: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'
INFO: 2020-11-14 11:24:26,508: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-11-14 11:24:26,508: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'
INFO: 2020-11-14 11:24:26,508: download_one() 'Wallhaven.cc: Downloading an image, config: https://wallhaven.cc/search?q=drawings&categories=110&purity=100&sorting=relevance&order=desc'
INFO: 2020-11-14 11:24:26,508: download_one() 'Wallhaven.cc: Queue size: 0'
INFO: 2020-11-14 11:24:26,509: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-11-14 11:24:26,509: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'
INFO: 2020-11-14 11:24:26,509: download_one() 'Wallhaven.cc: Filling queue'
INFO: 2020-11-14 11:24:26,509: search() 'Performing wallhaven search: url=https://wallhaven.cc/search?q=drawings&categories=110&purity=100&sorting=relevance&order=desc'

so it's not caused by an id for example in the search since I've changed to a keyword

and it download 3 images from the search while still being able to list 3252 wallpapers in the search

changemenemo commented 3 years ago

it doesn't seem to happen in my gnome boxes of fedora 33 but with xfce4 maybe it's related or maybe I'm missing a requirements on my main host

changemenemo commented 3 years ago

nothing then? At least to tell me that maybe it's normal because of this or this, or that those logs doesn't reveal anything strange? Waht's the ! Could not parse Wallhaven.cc serverside options, using defaults 360, 40'

changemenemo commented 3 years ago

New version of variety 0.8.5-3.fc33.noarch still the same problem. Please advise on the situation

peterlevi commented 3 years ago

This issue does not happen on my machine: 

INFO: 2020-11-14 11:12:41,614: get_throttling() 'Could not parse Wallhaven.cc serverside options, using defaults 360, 40'

But it should be irrelevant to your problem. Please open the Color and Size tab in Variety Preferences and uncheck all checkboxes there, then see if the problem continues.

Also, please attach some more of the relevant logs - those parts that contain the numbers of search results. E.g. my log looks like this:

INFO: 2020-12-15 00:44:13,172: get_throttling() 'Wallhaven.cc: parsing serverside options'
INFO: 2020-12-15 00:44:13,172: get_throttling() 'Wallhaven.cc serverside options: {'min_fill_queue_interval': 1800, 'min_download_interval': 1800}'
INFO: 2020-12-15 00:44:13,173: download_one() 'Wallhaven.cc: Filling queue'
INFO: 2020-12-15 00:44:13,173: search() 'Performing wallhaven search: url=https://wallhaven.cc/search?q=bokeh&categories=111&purity=100&sorting=favorites&order=desc'
INFO: 2020-12-15 00:44:13,892: fill_queue() '3324 wallpapers in result, using page 9'
INFO: 2020-12-15 00:44:13,892: search() 'Performing wallhaven search: url=https://wallhaven.cc/search?q=bokeh&categories=111&purity=100&sorting=favorites&order=desc&page=9'
INFO: 2020-12-15 00:44:14,583: download_one() 'Wallhaven.cc: Queue populated with 12 URLs'
INFO: 2020-12-15 00:44:14,583: download_queue_item() 'Wallpaper URL: https://wallhaven.cc/w/2ed8mx'
changemenemo commented 3 years ago

To be fair, it doesn't happen on my VMs either. But on the other hand, my fedora VMs are not using gnome shells but xfce. I ok not this host is using it and has problems with it.

When I did relaunch it now like you ask me to configure it. At first it was giving me the same error message then it began to actually download new images and then no error messages. Just throttling messages etc. So I guess that was it.... I m just bothered by those error messages. What are those could you enlighten me ?

I m going to monitor the situation and see if it actually finds out new wallpaper again and again or if it stops after some.