search

varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.13k stars 137 forks source link

Cooperation help #572

Closed TornaxO7 closed 1 year ago

TornaxO7 commented 1 year ago

Hello! Leftwm-Contributor here :)

Someone created an issue which shows that this horizontal scrolling doesn't work. May I ask you if you could quickly show the relevant part of your code which detects if the mouse is on the left/right, ready to scroll horizontaly? Thanks!

peterlevi commented 1 year ago

Hi. It seems as a whole the window size and position is not computed correctly. The logic for this thumbnail window and its scrolling is in ThumbsWindow.py. Specifically the scrolling logic is here: https://github.com/varietywalls/variety/blob/61606a62d2e2af24e7fa84834d808df8ad5e6115/variety/ThumbsWindow.py#L389 The mouse event handlers are at https://github.com/varietywalls/variety/blob/61606a62d2e2af24e7fa84834d808df8ad5e6115/variety/ThumbsWindow.py#L75-L89, they just record the mouse position, the logic in the autoscroll_thread actually drives the scrolling depending on where the mouse is. Window sizing and positioning logic is at https://github.com/varietywalls/variety/blob/61606a62d2e2af24e7fa84834d808df8ad5e6115/variety/ThumbsWindow.py#L263.

TornaxO7 commented 1 year ago

Thank you for the information! I'll close this issue for the time being.