search

varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.21k stars 146 forks source link

Customizable Unsplash API key #602

Closed zopieux closed 1 year ago

zopieux commented 1 year ago

Version of Variety you are using

0.8.10

Is your feature request related to a problem? Please describe.

Yes, the Unsplash API key is hardcoded and often gets throttled, leading to a degraded experience. See #332.

Describe the solution you'd like

Please add a field for a custom Unsplash API key, as it's relatively easy for savvy folks to register a demo app from Unsplash and release pressure on the hardcoded one.

Additional context

n/a

peterlevi commented 1 year ago

Sorry, but registering a demo app to use the API key for Variety would be a violation of all sorts of agreements with Unsplash (between both Variety and them and the user and them) and would be plain unethical. The relationship with them has anyway not been easy, I am very much not inclined to strain it further. The throttling is there not for apps to find ways to bypass it, but so that they can continue providing a free service.

zopieux commented 1 year ago

Thanks for the feedback. I'm a bit surprised about the opinion that registering an app would be considered “unethical” in this setting. If anything, this represents the opportunity for Unsplash themselves to ban my app without impacting the rest of the users, if they consider my usage not compliant.

Nevertheless, I can get behind your sentiment.

mtariqsajid commented 1 year ago

@peterlevi my variety never download wallpaper not even one from Unsplash what should i do ?