search

varietywalls / variety

Wallpaper downloader and manager for Linux systems
http://peterlevi.com/variety
GNU General Public License v3.0
1.12k stars 137 forks source link

Not changing wallpaper on Plasma 6 Wayland #672

Closed derekagraham78 closed 5 months ago

derekagraham78 commented 6 months ago

Version of Variety

variety 0.8.10

Describe the bug

Open up variety, wallpaper doesnt change.

Context

Happens everytime, no matter if im on X11 or Wayland.

To Reproduce

  1. Open Variety
  2. Try to change wallpaper
  3. wallpaper doenst change from what plasma has set

Attach Variety's log file

Log variety.log

Desktop environment and version

Plasma 6 KDE Plasma Version:5.91.0 KDE Frameworks Version: 5.247.0 QT Version: 6.6.1

OS name and version

BUG_REPORT_URL="https://github.com/NixOS/nixpkgs/issues" BUILD_ID="24.05.20231222.6df37dc" DOCUMENTATION_URL="https://nixos.org/learn.html" HOME_URL="https://nixos.org/" ID=nixos LOGO="nix-snowflake" NAME=NixOS PRETTY_NAME="NixOS 24.05 (Uakari)" SUPPORT_URL="https://nixos.org/community.html" VERSION="24.05 (Uakari)" VERSION_CODENAME=uakari VERSION_ID="24.05"

Screenshots

Attached files

Attached log file

Additional context

farchord commented 5 months ago

Running on 0.8.11 here, same problem. Running on plasma 6, and the wallpaper wont change either.

I tried to apply https://github.com/varietywalls/variety/pull/673 but it didn't seem to fix it.

Operating System: Fedora Linux 40 KDE Plasma Version: 5.92.0 KDE Frameworks Version: 5.248.0 Qt Version: 6.6.1 Kernel Version: 6.8.0-0.rc0.20240112git70d201a40823.5.fc40.x86_64 (64-bit) Graphics Platform: Wayland Processors: 24 × AMD Ryzen 9 5900X 12-Core Processor Memory: 62.7 GiB of RAM Graphics Processor: AMD Radeon RX 6900 XT

ReillyBrogan commented 5 months ago

I figured it out. PR #673 DOES fix it however the script that Variety calls to set the wallpaper is at ~/.config/variety/scripts/set_wallpaper and Variety only replaces this file with the version in data/ if the Variety version has been increased since the last time it was ran.

You can manually override this file by doing a cp path/to/variety/repo/data/scripts/set_wallpaper ~/.config/variety/scripts/set_wallpaper and it should start working immediately, no need to restart Variety.

@jlu5 Could we get a new version tagged so that packagers pick it up? The Plasma 6 release is next month and it would be great if it could be supported in advance (especially for folk like me and the others in this thread who are currently working on testing/packaging it so it's ready for the big release).

farchord commented 5 months ago

I figured it out. PR #673 DOES fix it however the script that Variety calls to set the wallpaper is at ~/.config/variety/scripts/set_wallpaper and Variety only replaces this file with the version in data/ if the Variety version has been increased since the last time it was ran.

You can manually override this file by doing a cp path/to/variety/repo/data/scripts/set_wallpaper ~/.config/variety/scripts/set_wallpaper and it should start working immediately, no need to restart Variety.

@jlu5 Could we get a new version tagged so that packagers pick it up? The Plasma 6 release is next month and it would be great if it could be supported in advance (especially for folk like me and the others in this thread who are currently working on testing/packaging it so it's ready for the big release).

Yup, that worked!

jlu5 commented 5 months ago

I've tagged 0.8.12 which includes this fix