search

varigit / meta-variscite-bsp-imx

BSP layer for Variscite SOMs using NXP i.MX SoCs. Contains hardware-specific metadata and configurations.
https://variwiki.com
Other
6 stars 17 forks source link

variscite_ubi.inc: IMAGE_DEPENDS on bc-native #9

Closed moto-timo closed 2 years ago

moto-timo commented 2 years ago

Because multiubi_mkfs:prepend() pipes to 'bc', we need to add 'bc-native' to IMAGE_DEPENDS:multiubi (rather than DEPENDS, which is global and causes dependency loops).

Signed-off-by: Tim Orling tim.orling@konsulko.com

nsdrude commented 2 years ago

@varigigi can you please review? See the original PR here: https://github.com/varigit/meta-variscite-sdk/pull/2

varigigi commented 2 years ago

@moto-timo, although our builds complete successfully even without this change, it looks reasonable. Is this just required to make the build independent from the packages actually installed on the building host ? I'm asking because in our build instruction, we list "bc" in the packages to be installed before building.

moto-timo commented 2 years ago

This file is only included for the following machines:

.../meta-variscite-bsp$ grep -R variscite_ubi.inc
 conf/machine/var-som-mx6.conf:require variscite_ubi.inc
 conf/machine/imx6ul-var-dart.conf:require variscite_ubi.inc
 conf/machine/imx7-var-som.conf:require variscite_ubi.inc

So if you are not building for one of those targets, you will not see a problem in your builds.

My host has bc installed, but since bc is not in HOSTTOOLS it is not available in the build. The multiubi image type cannot be built because the multiubi_mkfs task will fail with bc: file not found (paraphrasing).