Change u-boot-splash recipe to allow appends to change the splash image.

varigit / meta-variscite-fslc

Variscite BSP layer for FSL community BSP

19 stars 47 forks source link

Closed cdgarren closed 5 years ago

eranmati commented 5 years ago

Hi Chris. Thanks for the patch and sorry for the delayed response.

I have a few comments:

'S = "${WORKDIR}"' is missing in order for the new do_install to work
I prefer 'FILES_${PN}' to remain "/boot/splash.bmp" and not "/boot", since splash.bmp is the only file in this package
In the assignment of SRC_URI, '=' makes more sense than '+='

Regards, Eran

cdgarren commented 5 years ago

Eran, Thanks for the suggestions. I've just pushed up the requested changes.

Thanks, Chris

eranmati commented 5 years ago

Patch pushed. Thanks.