varkor / pokengine

An online Pokémon battle system for the web
http://varkor.com/pokengine/battle/
MIT License
54 stars 11 forks source link

Species data should be stored in Pokémon #100

Closed varkor closed 9 years ago

varkor commented 10 years ago

It would be easier to revert to the old system of storing an actual object in pokemon.species (obviously this will have to be changed to the string upon pokemon.store() and vice versa). However, it should not be a reference, but a copy, which can include differences as per the form(e) of the Pokémon.

varkor commented 9 years ago

Quite frankly, for now, I'd rather keep the system as it is. I think it works well enough, and changing it would just cause confusion. We may review this decision later on, but for now I'm going to close this issue.