search

varlevi / ShadeSwash

An online web app to be used by web designers and developers that returns all the shades of a color the user inputs.
https://shadeswash.netlify.app
MIT License
7 stars 1 forks source link

Added Dark Mode to website #12 #17

Closed wajeehsheikh closed 5 years ago

wajeehsheikh commented 5 years ago

Hi,

  1. Added Dark mode to the_shade_generator website.
  2. Added a button on the bottom left of the website to change to dark mode and back.
Screen Shot 2019-10-28 at 8 30 57 PM

Hope you like it.

Thank you Wajeeh

varlevi commented 5 years ago

This looks really great! The problem is that I believe it is inverting the page, which means the shades colors don't come out right. I'm pretty new to GitHub, so I'm not really sure how to add pictures, but the issue is pretty easy to replicate. Just enter the digits and generate. You can see what color is showing up. Then, press the dark mode button, and the shades change, but the digits don't.

cdrani commented 5 years ago

@varlevi @wajeehsheikh : I believe that would be an easy fix. According to the docs just adding the class darkmode-ignore to the elements that render the shades should be the fix.

varlevi commented 5 years ago

Alright. I added the darkmode-ignore class, which worked very well. Thanks!