varlink / go

Golang implementation of the Varlink protocol
https://godoc.org/github.com/varlink/go/varlink
Apache License 2.0
55 stars 57 forks source link

Add go mod file #12

Closed johanbrandhorst closed 4 years ago

johanbrandhorst commented 4 years ago

Fixes #11

johanbrandhorst commented 4 years ago

I would also ask if we can retire 1.10.x and 1.11.x? These releases are no longer supported by the official go project, since the release of 1.13.x.

haraldh commented 4 years ago

Those requirements are only for the cmd. Can the go.mod file be moved there?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 338


Totals Coverage Status
Change from base Build 335: 0.0%
Covered Lines: 571
Relevant Lines: 691

💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 328


Totals Coverage Status
Change from base Build 327: 0.0%
Covered Lines: 1713
Relevant Lines: 2073

💛 - Coveralls
purpleidea commented 4 years ago

I'd NACK. Please see: https://github.com/varlink/go/issues/11#issuecomment-536488389

johanbrandhorst commented 4 years ago

Those requirements are only for the cmd. Can the go.mod file be moved there?

I can move the go.mod file to ./cmd, but it can be a bit of a pain to have several modules per repository (https://github.com/golang/go/wiki/Modules#should-i-have-multiple-modules-in-a-single-repository). Are you sure?

haraldh commented 4 years ago

Moved the CLI tool to https://github.com/varlink/go-varlink-cmd .. so the go mod file should not be necessary

johanbrandhorst commented 4 years ago

As long as the generated files import github.com/varlink/go/varlink there will be a benefit to using a go.mod file. Are you planning on removing that import path?

johanbrandhorst commented 4 years ago

Friendly bump.