Open joonas-fi opened 4 months ago
https://github.com/varlink/go/blob/38f589fef6e11cd44a3206a4b6037a8693fef8e1/varlink/connection.go#L298-L304
This doesn't seem to do anything? Each case branch is essentially no-op (contains bare break), yet contains no default branch which could have implemented validating protocol to have valid values (unix, tcp)..
break
default
protocol
unix
tcp
The block is confusing :thinking:
https://github.com/varlink/go/blob/38f589fef6e11cd44a3206a4b6037a8693fef8e1/varlink/connection.go#L298-L304
This doesn't seem to do anything? Each case branch is essentially no-op (contains bare
break
), yet contains nodefault
branch which could have implemented validatingprotocol
to have valid values (unix
,tcp
)..The block is confusing :thinking: