varlink / go

Golang implementation of the Varlink protocol
https://godoc.org/github.com/varlink/go/varlink
Apache License 2.0
55 stars 57 forks source link

`NewConnection` has code block that does nothing #33

Open joonas-fi opened 4 months ago

joonas-fi commented 4 months ago

https://github.com/varlink/go/blob/38f589fef6e11cd44a3206a4b6037a8693fef8e1/varlink/connection.go#L298-L304

This doesn't seem to do anything? Each case branch is essentially no-op (contains bare break), yet contains no default branch which could have implemented validating protocol to have valid values (unix, tcp)..

The block is confusing :thinking: