varmd / wine-wayland

Wine-wayland allows playing DX9/DX11 and Vulkan games using pure wayland and Wine/DXVK.

729 stars 14 forks source link

Replace hardcoded browser list with xdg-open #66

Closed ghost closed 7 months ago

ghost commented 1 year ago

61 continued

varmd commented 1 year ago

PR would break the use-case when user has no default browsers from xdg-open or xdg-open is not configured. So the PR should first run xdg-open, check the return code and run open_url if not successfull.

ghost commented 1 year ago

So the PR should first run xdg-open, check the return code and run open_url if not successfull.

That's what it does

https://github.com/varmd/wine-wayland/pull/66/files#diff-1f5dd52c97fab1418859bf9b55bca37fb7fd0164191536d091e50ca6e9a44205R55-R59

varmd commented 1 year ago

No, it just checks for existence of xdg-open. It needs to run xdg-open and check the return code $?

ghost commented 1 year ago

Sorry, I misunderstood. How about now?