Closed J0WI closed 3 years ago
Hi,
Some context: I upstreamed a couple of patches last year I believe, but then we broke that again, and Alpine keeps patching the packages without upstreaming them. The plan is to realign upstream and Alpine for the september release, and possibly add some CI to avoid things breaking again.
But, even with the patches, make check
doesn't fully passes on Alpine, and this is an upstream issue, and we can't do anything until that is fixed.
I will keep this ticket around because I know you won't be the last to ask about it, but work needs to be done upstream first before it becomes relevant.
@gquintard I found an unofficial Varnish image based on Alpine. https://github.com/Hermsi1337/docker-varnish/blob/master/varnish-65/Dockerfile. Are problems with make check
still relevant?
hi, actually, the varnish project now tests and even packages for alpine
(but doesn't distribute the apk
s) so the compilation issues are behind us.
and I've just checked now and packagecloud apparently supports alpine
, so it worth revisiting. But packages need to be pushed befofe we do anything here
Is there an issue to track the apk distribution? In the meantime varnish could be build from source in the Dockerfile.
looks like packagecloud.io is still the blocker and doesn't really support apk
files, so yes, building the files in the Dockerfile
is possibly the best option. And there's already a script for that: https://github.com/varnishcache/varnish-cache/blob/master/.circleci/make-apk-packages.sh
Really, all that is needed is a kind soul with the bandwidth to actually do the work and open a PR
I can provide a poc Dockerfile. How do you plan to integrate this with your populate.sh
?
The entrypoint scripts need some adjustments to work with the self compiled version.
cheers. Shouldn't we build packages and install those, or is that jumping through too many hoops?
You just said that your infrastructure cant' distribute apk
packages
Indeed, but it does build them. So we can create the APK files and install those, all in the Dockerfile.
I usually avoid to litter my root filesystems with unpackaged files, but in the docker case, it may not be that important, I don't know.
-- Guillaume Quintard
On Sat, Jul 3, 2021, 04:18 J0WI @.***> wrote:
You just said that your infrastructure cant' distribute apk packages
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/varnish/docker-varnish/issues/2#issuecomment-873392004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42AKPTQ4JUM7264SZWTITTV3WY5ANCNFSM4H7QMEEA .
Indeed, but it does build them.
Including ARM etc? If you provide a download url I'll update the POC.
here's an example: https://app.circleci.com/pipelines/github/varnishcache/varnish-cache/2471/workflows/bc802559-f3e8-4e17-9e65-244d144d7e04
we'd have to do build the packages in here though, because we can't trust circleci to keep the artifacts around
here's an example
it's not public.
arf, it should be public, but will require a circleci account. The script building the packages is here: https://github.com/varnishcache/varnish-cache/blob/master/.circleci/make-apk-packages.sh and relying on this repo: https://github.com/varnishcache/pkg-varnish-cache/tree/master/alpine
now live on the hub
Would be great to have a variant based on the lightweight Alpine Linux base image.
https://hub.docker.com/_/alpine
Alpine currently requires some tiny patches to build Varnish on musl-libc. This could be fixed upstream: https://git.alpinelinux.org/aports/tree/main/varnish?h=master