search

varnish / libvmod-digest

Digest and HMAC vmod
Other
50 stars 27 forks source link

Varnish 6.2.0 compatibility #30

Closed cst152 closed 5 years ago

cst152 commented 5 years ago

Changed to vmod function prefixes to match the requirements of varnish 6.2.0.

cst152 commented 5 years ago

Hm, as far as I can see, it's incompatible with Varnish 4 now...

dridi commented 5 years ago

Varnish 4.x series are EOL anyway, so users can stick to older vmod-digest releases if that's what they want.

Thank you for your contribution, I will review it when I have time!

cst152 commented 5 years ago

I'm sorry, I tested a little more and realized that this solution also fails with Varnish 6.0.0 and 6.1.0. I'll see if I can fix this.

cst152 commented 5 years ago

Now it works. Feels like a bit of a hack, though...

dridi commented 5 years ago

I took the liberty of squashing your commits and added a few more changes. In #29 I gave you the example of the vmod-querystring migration and it technically didn't touch the function names (in my case only optional arguments were clashing between 6.0 and 6.2).

So the hacky feeling mostly comes from using macros for more than "just the $Event function" which was probably the only offending symbol.