search

varnish / libvmod-example

An example vmod for Varnish Cache
https://varnish-cache.org/vmods/
53 stars 74 forks source link

use the python we found in case it's not called "python" #31

Closed nigoroll closed 8 years ago

nigoroll commented 8 years ago

/usr/bin/env python in vmodtool.py does not work for cases where it's called python$VERSION, e.g. python2.7 - as is the case on SmartOS with pkgin

nigoroll commented 8 years ago

I added another commit to my repo, so the pull request name only reflects half the story now.

lkarsten commented 8 years ago

Thanks!

nyov commented 8 years ago

First, thanks for this liberally licensed example vmod. Helped me getting a quick start with current vmods.

But, alas, I think this commit introduced license issues. m4/ax_pthread.m4 is quite obviously GPL3-licensed. And in another instance, debian/copyright has a BSD license. (Though I noticed that got removed entirely now.) The first, or both, instances should probably at least be noted in the LICENSE file.

nigoroll commented 8 years ago

the autoconf macros are only used to build configure, so my understanding is that they do not impact the vmod license.

dridi commented 8 years ago

@nyov, this module is in the public domain according to the LICENSE file, feel free to remove any copyleft material when you derive work from it.

nyov commented 8 years ago

Okay, thanks.