search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
182 stars 86 forks source link

Regular expression support in vmod-cookie #126

Closed lkarsten closed 4 years ago

lkarsten commented 5 years ago

Hi.

This PR adds regular expression support in vmod-cookie.

Please consider this for merging into varnish-modules.

lkarsten commented 5 years ago

@nigoroll I think I got it all. Feedback appreciated.

lkarsten commented 5 years ago

Hi. Any chance of getting this merged into varnish-modules? I'm happy to adapt/fix the changeset further if that is required.

lkarsten commented 5 years ago

Hi.

Is there anything I can do to move this along?

marcaddeo commented 5 years ago

Would love to see this merged in as well. Would be very useful in the case of randomized session cookie identifiers.

nigoroll commented 5 years ago

@lkarsten as you know I am not the maintainer, but I would love to merge this into my master fork at https://github.com/nigoroll/varnish-modules And with that hat on I would appreciate if you consolidated your PR into a smaller number of commits (one?)

gquintard commented 4 years ago

Hi @lkarsten, sorry for leaving you hanging. We'll gladly take the request once @nigoroll's remarks have been address and the commits squashed. I'll have one last review right before merging but I trust Nils to have caught pretty much everything

lkarsten commented 4 years ago

Hi @gquintard .

I've since moved to other tasks with other customers, and I don't have the time or inclination to follow up on this.

If anyone needs this, please be in touch and I can help you along.

PS: Thank you @nigoroll for the code review.

-Lasse

nigoroll commented 4 years ago

continued in #146 after consent 1:1 from @lkarsten