search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
185 stars 86 forks source link

xkey stats #145

Closed benzvan closed 4 years ago

benzvan commented 4 years ago

I'd love to be able to track stats on xkey use including number of keys and size of key storage space. I don't currently see anything coming out of varnishstat related to these metrics in varnish 6.

gquintard commented 4 years ago

Hi @benzvan,

xkey is considered feature-complete meaning that we aren't against studying pull requests, but we won't invest development time into new features.

benzvan commented 4 years ago

OK. Would you consider merging a pull request for this new feature?

gquintard commented 4 years ago

the policy (in the README) is that we will only accept bug and security fixes for that vmod

nigoroll commented 4 years ago

Re @benzvan

OK. Would you consider merging a pull request for this new feature?

my fork https://github.com/nigoroll/varnish-modules is starting to diverge anyway and I would consider one.

gquintard commented 4 years ago

So, let me walk that one back after having talked to the team: we'll take PRs as long as the code is clean and useful to the majority of users.

@nigoroll, repos are pretty much aligned at the moment, aren't they?

nigoroll commented 4 years ago

@gquintard Oh right, I actually missed the fact that you did pick up our commits. Thank you :)

benzvan commented 4 years ago

ok. I feel like visibility should be useful for the majority of users, so I'll get a story on our backlog for this.