search

varnish / varnish-modules

Collection of Varnish Cache modules (vmods) by Varnish Software
Other
185 stars 86 forks source link

add regular expression filtering to vmod_cookie #146

Closed nigoroll closed 4 years ago

nigoroll commented 4 years ago

Follow up to #126, basically just squashing and polishing @lkarsten s work

gquintard commented 4 years ago

Ok for me apart from one round of bikeshedding: can we call the functions .something_regex() instead of something_re()?

nigoroll commented 4 years ago

@gquintard sure will adjust

nigoroll commented 4 years ago

force-pushed

lkarsten commented 4 years ago

-100 on renaming functions one year after the code was written and taken into use.

nigoroll commented 4 years ago

@lkarsten I guess a compat-wrapper would be easy. And I totally understand your frustration as someone who has a varnish-cache PR open which just turned 1 year.

nigoroll commented 4 years ago

btw @lkarsten and @gquintard if you can sort this out between each other, I am fine with whatever name. I really only wanted to help get this useful feature merged.

gquintard commented 4 years ago

-100 on renaming functions one year after the code was written and taken into use.

I'd argue that the code never made it to the repo so it should be irrelevant, but since we let it sit for so long, I'll abide.

I'll rename, squash then merge.

gquintard commented 4 years ago

I haven't squashed to avoid losing the authors. Thanks to both of you